Bugfix: Butex returned to ObjectPool triggers use-after-poison#3012
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents ASan from poisoning memory for TaskNode and Butex objects returned to their respective object pools, avoiding use-after-poison errors.
- Adjusted comment style in
execution_queue_inl.hforTaskNode::cancel(). - Added ASan-poison specialization for
bthread::Butexinbutex.cpp. - Updated Chinese documentation with examples for disabling ASan poisoning on object pools.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/bthread/execution_queue_inl.h | Refined comment formatting for TaskNode::cancel(). |
| src/bthread/butex.cpp | Added ObjectPoolWithASanPoison<bthread::Butex> specialization. |
| docs/cn/sanitizers.md | Included example for disabling ASan poisoning on Butex. |
Comments suppressed due to low confidence (1)
src/bthread/butex.cpp:131
- Consider adding a unit or integration test to verify that the ASan poison specialization for
Butexprevents poisoning as intended.
struct ObjectPoolWithASanPoison<bthread::Butex> : false_type {};
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2890
Problem Summary:
What is changed and the side effects?
Changed:
Butex object returned to the ObjectPool may be accessed, so ObjectPool can not poison the memory region of Butex.
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: